Skip to content

fix(loader): reject missing values before Flink - #72

Closed
imbajin wants to merge 1 commit into
masterfrom
fix/cdc-launcher-missing-values
Closed

imbajin wants to merge 1 commit into
masterfrom
fix/cdc-launcher-missing-values

Conversation

@imbajin

@imbajin imbajin commented Oct 14, 2026 •

Copy link
Copy Markdown

Purpose of the PR

A CDC command ending with --password or --file could invoke Flink before Loader reported the missing value. The launcher now rejects that trailing missing value before invoking Flink, using the existing Loader argument grammar and preserving the original Flink/Loader argument boundaries.

Follow-up to the CDC launcher review. The Flink CDC guide documents the rejection behavior.

Verifying these changes

The launcher regression reproduces the previous invocation and now verifies that Flink is never called for a trailing missing value. Existing argument-boundary, credential-output and ordinary Loader checks, ShellCheck and shell syntax checks passed. Independent reviews found no blocking issue.

Does this PR potentially affect the following parts?

  • Other affects: CDC launcher validation before submission.

Documentation Status

  • Doc - Done

ASF counterpart: apache#819.

- reuse the existing option parser before CDC submission
- preserve engine and Loader argument boundaries
- cover trailing missing values and document rejection
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b10c6948-e85d-4440-ba56-b12bfdd3ba9c
📥 Commits

Reviewing files that changed from the base of the PR and between 8e6ed84 and 7db3fb2.

📒 Files selected for processing: 34
  • .asf.yaml
  • .github/labeler.yml
  • .github/scripts/check-rerun.py
  • .github/scripts/ci-policy.py
  • .github/scripts/java17_image.py
  • .github/scripts/test_candidate_sdk.py
  • .github/scripts/test_check_rerun.py
  • .github/scripts/test_ci_policy.py
  • .github/scripts/test_java17_image.py
  • .github/workflows/ci.yml
  • .github/workflows/client-ci.yml
  • .github/workflows/client-go-ci.yml
  • .github/workflows/codeql-analysis.yml
  • .github/workflows/dependency-license.yml
  • .github/workflows/flink-cdc-ci.yml
  • .github/workflows/hubble-ci.yml
  • .github/workflows/hubble-launcher-ci.yml
  • .github/workflows/image-ci.yml
  • .github/workflows/java17-images-ci.yml
  • .github/workflows/labeler.yml
  • .github/workflows/license-checker.yml
  • .github/workflows/loader-ci.yml
  • .github/workflows/rerun-ci.yml
  • .github/workflows/spark-connector-ci.yml
  • .github/workflows/spark-loader-ci.yml
  • .github/workflows/tools-ci.yml
  • .github/workflows/upstream-compatibility.yml
  • docs/ci.md
  • hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/BatchEdgeRequest.java
  • hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/BatchVertexRequest.java
  • hugegraph-client/src/test/java/org/apache/hugegraph/unit/BatchElementRequestTest.java
  • hugegraph-loader/assembly/static/bin/hugegraph-flinkcdc-loader.sh
  • hugegraph-loader/docs/flink-cdc-java17.md
  • hugegraph-loader/src/test/scripts/flink-launcher.test.cjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.06%. Comparing base (8e6ed84) to head (7db3fb2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     47.04%   47.06%   +0.02%     
  Complexity     4518     4518              
============================================
  Files           602      602              
  Lines         29448    29452       +4     
  Branches       3454     3456       +2     
============================================
+ Hits          13854    13862       +8     
+ Misses        14312    14308       -4     
  Partials       1282     1282              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imbajin

imbajin commented Oct 14, 2026

Copy link
Copy Markdown
Author

The matching source change has been merged in apache#819. Closing this duplicate tracking PR. The earlier CI failure remains recorded; closing this PR does not claim it has been fixed.

@imbajin imbajin closed this Oct 14, 2026
@imbajin
imbajin deleted the fix/cdc-launcher-missing-values branch October 14, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant