Repository navigation
Conversation
- reuse the existing option parser before CDC submission - preserve engine and Loader argument boundaries - cover trailing missing values and document rejection
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
============================================
+ Coverage 47.04% 47.06% +0.02%
Complexity 4518 4518
============================================
Files 602 602
Lines 29448 29452 +4
Branches 3454 3456 +2
============================================
+ Hits 13854 13862 +8
+ Misses 14312 14308 -4
Partials 1282 1282 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The matching source change has been merged in apache#819. Closing this duplicate tracking PR. The earlier CI failure remains recorded; closing this PR does not claim it has been fixed. |
Purpose of the PR
A CDC command ending with
--passwordor--filecould invoke Flink before Loader reported the missing value. The launcher now rejects that trailing missing value before invoking Flink, using the existing Loader argument grammar and preserving the original Flink/Loader argument boundaries.Follow-up to the CDC launcher review. The Flink CDC guide documents the rejection behavior.
Verifying these changes
The launcher regression reproduces the previous invocation and now verifies that Flink is never called for a trailing missing value. Existing argument-boundary, credential-output and ordinary Loader checks, ShellCheck and shell syntax checks passed. Independent reviews found no blocking issue.
Does this PR potentially affect the following parts?
Documentation Status
Doc - DoneASF counterpart: apache#819.